Skip to content

Remove workaround and fix public interface testing by creating linodes to be offline #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezilber-akamai merged 1 commit into from
Aug 7, 2025
Merged

Remove workaround and fix public interface testing by creating linodes to be offline #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/integration/linodes/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,13 +321,9 @@ def linode_interface_public(linode_cloud_firewall):
interfaces='[{"public": {"ipv4": {"addresses": [{"primary": true}]}}, "default_route": {"ipv4": true, "ipv6": true }, "firewall_id":'
+ linode_cloud_firewall
+ "}]",
booted=False,
)

wait_until(linode_id=linode_id, timeout=300, status="running")

# TODO: add support of creating a offline linode in `create_linode` then remove this workaround
exec_test_command(BASE_CMDS["linodes"] + ["shutdown", linode_id])

wait_until(linode_id=linode_id, timeout=60, status="offline")

yield linode_id
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/linodes/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def create_linode(
disk_encryption=False,
interface_generation: str = None,
interfaces: str = None,
booted: bool = True,
):
# Base command
command = BASE_CMDS["linodes"] + [
Expand All @@ -78,6 +79,8 @@ def create_linode(
firewall_id,
"--disk_encryption",
"enabled" if disk_encryption else "disabled",
"--booted",
str(booted).lower(),
]

if interface_generation:
Expand Down
Loading