Fixed improperly nested engine_config arguments in Postgres DB creation#778
Merged
ezilber-akamai merged 2 commits intolinode:devfrom Jun 2, 2025
Merged
Conversation
Member
zliang-akamai
left a comment
There was a problem hiding this comment.
Can we wrap these logic into a function without bloating the _build_request_body function?
Contributor
|
@ezilber-akamai As a more generic alternative would it make sense to escape the e.g. would be instead stored internally as Example: lgarber-akamai@f50b8d7 |
ee941bf to
301e938
Compare
ykim-akamai
approved these changes
May 30, 2025
Contributor
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, all tests passed. Nice work!
zliang-akamai
approved these changes
May 31, 2025
Member
zliang-akamai
left a comment
There was a problem hiding this comment.
Very cool way to handle that escaping thing! Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixed the following improperly nested fields in Postgres Database Creation:
✔️ How to Test
The following test steps require that the CLI is build against the latest API spec.
Integration Testing
Run the integration test suite to ensure that this fix did not break unrelated functionality:
make test-intManual Testing
Run the following command and ensure that the database is properly created and json is properly printed: