Add and update test coverage for spec v4.199.0#774
Conversation
There was a problem hiding this comment.
Looks great, thanks for handling this!
Just an FYI, the Linode tests only seem to pass when the interfaces_for_new_linodes account setting is set to legacy_config_default_but_linode_allowed and the LINODE_CLI_API_VERSION env var is set to v4beta. We might want to update our tests to specify an explicit interface_generation during the creation of instances.
I'm not sure if this will have an impact on users but I'd imagine we should vet that this release (along with the other Linode Interface releases) won't break users who don't have access to the new feature.
Updated the tests and helper function. Refer to comment in PR for more details |
| firewall_id: str, | ||
| test_region=DEFAULT_REGION, | ||
| disk_encryption=False, | ||
| interface_generation: str = None, |
There was a problem hiding this comment.
We can use this helper function to specifically use legacy or new interface. It will create a legacy linode If none
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def linode_interface_legacy(linode_cloud_firewall): |
There was a problem hiding this comment.
e.g. Create linode with legacy config
📝 Description
New API spec 4.199.0 - https://github.com/linode/linode-api-docs/releases/tag/v4.199.0
Add test coverage for following commands:
✔️ How to Test
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.