Error on missing x-linode-cli-command extension; log when operationId is used for action#757
Merged
lgarber-akamai merged 4 commits intolinode:devfrom Apr 11, 2025
Conversation
lgarber-akamai
added
the
improvement
lgarber-akamai
requested review from
ezilber-akamai and
yec-akamai
and removed request for
a team
yec-akamai
approved these changes
Apr 11, 2025
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Works well on my end!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds logic to raise an error if an OpenAPI path has CLI-enabled actions but does not specify an
x-linode-cli-commandextension. This is necessary because we've recently had OpenAPI specification release candidates make it very far down the pipeline before commands misgrouped underdefaultare discovered, which is not intentionally used by any existing commands.This pull request also adds a new log entry that occurs when the
x-linode-cli-actionextension is not specified and the operationId is used as a failover.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing