Add conditions to notification job in e2e workflow#747
Merged
ykim-akamai merged 2 commits intolinode:devfrom Mar 18, 2025
Merged
Add conditions to notification job in e2e workflow#747ykim-akamai merged 2 commits intolinode:devfrom
ykim-akamai merged 2 commits intolinode:devfrom
Conversation
ykim-akamai
added
the
repo-ci-improvement
ykim-akamai
requested review from
ezilber-akamai and
lgarber-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Mar 17, 2025
lgarber-akamai
approved these changes
Mar 17, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
needs: [integration_tests, process-upload-report]The condition above was missed which was causing the summary to be empty during notification job
✔️ How to Test
Tested on forked and private channel
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.