Support primary/secondary on a per IP basis#5
Open
bbetter173 wants to merge 3 commits intolinode:masterfrom
Open
Support primary/secondary on a per IP basis#5bbetter173 wants to merge 3 commits intolinode:masterfrom
bbetter173 wants to merge 3 commits intolinode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to the one open here: #1
I have attempted to address the feedback given in that PR by comparing the IP addresses configured against those detected by the system and throwing an error if it is unable to find them.
For simplicity sake I have removed the previous functionality where it automatically detected the IP addresses and "just worked" (or not, as the case may be) but could re-add it back in if that's a blocker on this being merged.