Skip to content

LCORE- 1433: fixed linter issue + enable new linter rule#1289

Merged
tisnik merged 3 commits intolightspeed-core:mainfrom
tisnik:lcore-1433-fixed-linter-issue
Mar 9, 2026
Merged

LCORE- 1433: fixed linter issue + enable new linter rule#1289
tisnik merged 3 commits intolightspeed-core:mainfrom
tisnik:lcore-1433-fixed-linter-issue

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Mar 9, 2026

Description

LCORE- 1433: fixed linter issue + enable new linter rule

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1433

Summary by CodeRabbit

  • Chores

    • Updated linting configuration with an additional quality rule.
  • Style

    • Standardized UTC timezone handling across timestamp operations for improved consistency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 44a34bb5-ded6-457a-9af5-88cbd7a31e79

📥 Commits

Reviewing files that changed from the base of the PR and between cfaa6be and 2936c75.

📒 Files selected for processing (2)
  • src/app/endpoints/query.py
  • tests/unit/app/endpoints/test_conversations_v2.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/app/endpoints/query.py

Walkthrough

Adds UP017 to ruff lint configuration and standardizes UTC usage by replacing datetime.timezone.utc imports/usages with a UTC alias across code and tests for timestamp generation and parsing.

Changes

Cohort / File(s) Summary
Ruff Lint Configuration
pyproject.toml
Added UP017 to tool.ruff.lint.extend-select.
UTC Timezone Alias Migration
src/app/endpoints/a2a.py, src/app/endpoints/query.py, tests/unit/app/endpoints/test_conversations_v2.py
Replaced timezone/datetime.timezone.utc imports/usages with a UTC alias and updated timestamp generation/parsing to use UTC.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: enabling a new linter rule (UP017) and fixing UTC-related code to comply with linter standards.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/app/endpoints/query.py`:
- Around line 240-242: Run the code formatter (Black) on
src/app/endpoints/query.py to fix the formatting delta; specifically reformat
the completed_at assignment (variable completed_at in the file) so it matches
Black's style (i.e., wrap/indent the call arguments as Black would). Ensure you
run Black across the file (or project) and commit the resulting changes so CI
passes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 08bc927f-6ad0-4bd7-ae47-92c199ca279a

📥 Commits

Reviewing files that changed from the base of the PR and between 64bb63a and cfaa6be.

📒 Files selected for processing (3)
  • pyproject.toml
  • src/app/endpoints/a2a.py
  • src/app/endpoints/query.py

@tisnik tisnik merged commit d413f61 into lightspeed-core:main Mar 9, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant