LCORE-1215: Preparing for 0.4.2 release#1288
Conversation
WalkthroughThis release bump updates the project version from 0.4.1 to 0.4.2. Changes include updating the version constant, documentation, OpenAPI specification, telemetry examples, and test expectations across the codebase. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
README.md (1)
9-9: Link the badge to the latest release page.The badge text is dynamic already, but the target URL is pinned to
0.4.2, so this will need another manual edit on the next release. Pointing it at the latest release page removes that drift point.♻️ Suggested change
-[](https://github.com/lightspeed-core/lightspeed-stack/releases/tag/0.4.2) +[](https://github.com/lightspeed-core/lightspeed-stack/releases/latest)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 9, Update the badge link target so it always points to the latest release page instead of the pinned tag URL; locate the markdown badge string starting with "[ so the badge link automatically resolves to the newest release.tests/unit/app/endpoints/test_rlsapi_v1.py (1)
68-68: Derive the mocked User-Agent from the shared version constant.Hardcoding
CLA/0.4.2here means this helper needs a manual edit every release and can drift fromsrc/version.py. Building it from__version__keeps the test aligned automatically.♻️ Suggested change
from utils.suid import check_suid +from version import __version__ @@ - mock_request.headers = {"User-Agent": "CLA/0.4.2"} + mock_request.headers = {"User-Agent": f"CLA/{__version__}"}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/unit/app/endpoints/test_rlsapi_v1.py` at line 68, Replace the hardcoded User-Agent string with a value derived from the package version: import the module-level __version__ (e.g., from version import __version__ or from src.version import __version__) at the top of the test file and set mock_request.headers to use f"CLA/{__version__}" instead of "CLA/0.4.2"; update the import section to include __version__ so the test always reflects the current release version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Line 9: Update the badge link target so it always points to the latest release
page instead of the pinned tag URL; locate the markdown badge string starting
with "[ so the badge link automatically resolves to the
newest release.
In `@tests/unit/app/endpoints/test_rlsapi_v1.py`:
- Line 68: Replace the hardcoded User-Agent string with a value derived from the
package version: import the module-level __version__ (e.g., from version import
__version__ or from src.version import __version__) at the top of the test file
and set mock_request.headers to use f"CLA/{__version__}" instead of "CLA/0.4.2";
update the import section to include __version__ so the test always reflects the
current release version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a30d9749-5ffd-455a-adc0-6a8c7d90a8e4
📒 Files selected for processing (9)
README.mddocs/openapi.jsondocs/splunk.mdsrc/observability/README.mdsrc/version.pytests/e2e/features/info.featuretests/integration/endpoints/test_rlsapi_v1_integration.pytests/unit/app/endpoints/test_rlsapi_v1.pytests/unit/observability/formats/test_rlsapi.py
Description
LCORE-1215: Preparing for 0.4.2 release
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit