LCORE-1216: Fix wrong llama-stack-api version#1128
LCORE-1216: Fix wrong llama-stack-api version#1128are-ces wants to merge 1 commit intolightspeed-core:mainfrom
Conversation
WalkthroughDependency adjustments across build and lock files: a llama-stack-api version change in pyproject.toml, edits to requirements-build.txt (comments and tool versions), extensive hash/version updates in requirements.hashes.source.txt, and removals from requirements.hashes.wheel.txt. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
requirements-build.txt (1)
33-38:⚠️ Potential issue | 🟠 MajorResolve duplicate
hatchlingpins before release.The compiled requirements file contains two pinned versions of hatchling (1.26.3 on line 33 and 1.28.0 on line 38), generated by pybuild-deps during the build process. This happens because conflicting transitive dependencies cannot resolve to a single version—notably, hatch-fancy-pypi-readme appears in the dependency chains for both versions. Before releasing, regenerate the requirements by running
make konflux-requirementsafter ensuring your source constraints in pyproject.toml (or any constraint overrides) can be satisfied with a single hatchling version. If pybuild-deps still produces duplicates, investigate the version requirements of packages like hatch-fancy-pypi-readme, llama-stack-client, openai, a2a-sdk, einops, and related build dependencies.
tisnik
left a comment
There was a problem hiding this comment.
it's been bumped on purpose - to fix CVE
Description
llama-stack-apiversion should be0.4.3, same asllama-stackType of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit