[feat] Add configurable timeout for Llama Stack requests#1087
Merged
tisnik merged 1 commit intolightspeed-core:mainfrom Feb 1, 2026
Merged
[feat] Add configurable timeout for Llama Stack requests#1087tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik merged 1 commit intolightspeed-core:mainfrom
Conversation
Contributor
WalkthroughA timeout configuration field is added to the Llama Stack configuration with a default of 180 seconds, logged during client initialization, and passed to the AsyncLlamaStackClient constructor. Related test expectations are updated to reflect the new configuration field. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d213e81 to
8ecd66d
Compare
Introduces a timeout configuration parameter (default 180s) to accommodate long-running RAG queries and prevent premature request failures. Signed-off-by: Amit Oren <amoren@redhat.com>
8ecd66d to
8c0b029
Compare
Contributor
|
/ok-to-test |
Contributor
|
/ok-to-test |
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a timeout configuration parameter (default 180s) to accommodate long-running RAG queries and prevent premature request failures.
I did some work on POCing Lightspeed for a project in Red Hat OpenShift AI (the POC can be found in my repo).
Ran into some issues with slightly larger models where I timed out on RAG inference calls and had to increase Llama Stack timeouts. The change here implements this timeout extension. I thought it can be useful to others, hence the PR.
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
lightspeed-coreimage and deployed it on my OpenShift cluster to test this change.Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.