-
Notifications
You must be signed in to change notification settings - Fork 3
Add optional purpose of payment example to cross currency #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add optional purpose of payment example to cross currency #183
Conversation
c245df2 to
00339f7
Compare
Greptile OverviewGreptile SummaryAdded documentation for purpose of payment field in cross-currency quote requests. The accordion includes correct field name ( Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| mintlify/snippets/sending/cross-currency.mdx | Added accordion documenting purpose of payment field with correct codes and field name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
| "senderInfo": { | ||
| "purposeOfPayment": "GOODS_OR_SERVICES" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect field name - should be senderCustomerInfo not senderInfo
per openapi/components/schemas/quotes/QuoteRequest.yaml:47-66, the quote request uses senderCustomerInfo
| "senderInfo": { | |
| "purposeOfPayment": "GOODS_OR_SERVICES" | |
| } | |
| "senderCustomerInfo": { | |
| "PURPOSE_OF_PAYMENT": "GOODS_OR_SERVICES" | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 61:63
Comment:
incorrect field name - should be `senderCustomerInfo` not `senderInfo`
per openapi/components/schemas/quotes/QuoteRequest.yaml:47-66, the quote request uses `senderCustomerInfo`
```suggestion
"senderCustomerInfo": {
"PURPOSE_OF_PAYMENT": "GOODS_OR_SERVICES"
}
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo i think this one is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shuttt my b
| <Accordion title="Including purpose of payment"> | ||
| Some payment corridors require a purpose of payment. Include it in the `senderInfo` object: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add context about when this field is applicable
per the OpenAPI schema (openapi/components/schemas/quotes/QuoteRequest.yaml:47-51), senderCustomerInfo is "Only relevant for UMA destinations." this accordion doesn't clarify when purpose of payment is needed, which could confuse users trying to send to non-UMA destinations
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 52:53
Comment:
add context about when this field is applicable
per the OpenAPI schema (openapi/components/schemas/quotes/QuoteRequest.yaml:47-51), `senderCustomerInfo` is "Only relevant for UMA destinations." this accordion doesn't clarify when purpose of payment is needed, which could confuse users trying to send to non-UMA destinations
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.00339f7 to
9b19c48
Compare

No description provided.