Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions openapi/components/schemas/common/BrlAccountInfo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
type: object
required:
- pixKey
- pixKeyType
- taxId
properties:
pixKey:
type: string
description: The PIX key of the bank
pixKeyType:
type: string
description: The type of PIX key of the bank
taxId:
type: string
description: The tax ID of the bank account
50 changes: 50 additions & 0 deletions openapi/components/schemas/common/BrlBeneficiary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
type: object
required:
- fullName
properties:
fullName:
type: string
description: The full name of the beneficiary
birthDate:
type: string
description: The birth date of the beneficiary
nationality:
type: string
description: The nationality of the beneficiary
email:
type: string
description: The email of the beneficiary
phoneNumber:
type: string
description: The phone number of the beneficiary
registrationNumber:
type: string
description: The registration number of the beneficiary
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
type: object
required:
- country
- line1
- postalCode
properties:
line1:
type: string
description: Address line 1
postalCode:
type: string
description: Postal code
country:
type: string
description: Country code
line2:
type: string
description: Address line 2
city:
type: string
description: City
state:
type: string
description: State or province
10 changes: 10 additions & 0 deletions openapi/components/schemas/common/DkkAccountInfo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
type: object
required:
- iban
properties:
iban:
type: string
description: The IBAN of the bank
swiftBic:
type: string
description: The SWIFT BIC of the bank
50 changes: 50 additions & 0 deletions openapi/components/schemas/common/DkkBeneficiary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
type: object
required:
- fullName
properties:
fullName:
type: string
description: The full name of the beneficiary
birthDate:
type: string
description: The birth date of the beneficiary
nationality:
type: string
description: The nationality of the beneficiary
email:
type: string
description: The email of the beneficiary
phoneNumber:
type: string
description: The phone number of the beneficiary
registrationNumber:
type: string
description: The registration number of the beneficiary
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
type: object
required:
- country
- line1
- postalCode
properties:
line1:
type: string
description: Address line 1
postalCode:
type: string
description: Postal code
country:
type: string
description: Country code
line2:
type: string
description: Address line 2
city:
type: string
description: City
state:
type: string
description: State or province
19 changes: 4 additions & 15 deletions openapi/components/schemas/common/GbpAccountInfo.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,11 @@
type: object
required:
- sortCode
- accountNumber
- accountType
- sortCode
- accountNumber
properties:
accountType:
type: string
enum:
- GBP_ACCOUNT
sortCode:
type: string
description: UK bank sort code (6 digits, may include hyphens)
example: '20-00-00'
pattern: '^[0-9]{2}-?[0-9]{2}-?[0-9]{2}$'
description: The sort code of the bank
accountNumber:
type: string
description: UK bank account number (8 digits)
example: '12345678'
minLength: 8
maxLength: 8
pattern: ^[0-9]{8}$
description: The account number of the bank
Comment on lines 1 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed discriminator field
common/GbpAccountInfo.yaml no longer defines the accountType property (and it was removed from required). Since ExternalAccountInfoOneOf.yaml uses accountType as the discriminator property, GBP account payloads can no longer reliably validate/resolve to the correct schema variant.

This also drops the sort code/account number constraints (pattern/length), so invalid routing values will now pass schema validation.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/GbpAccountInfo.yaml
Line: 1:11

Comment:
**Removed discriminator field**
`common/GbpAccountInfo.yaml` no longer defines the `accountType` property (and it was removed from `required`). Since `ExternalAccountInfoOneOf.yaml` uses `accountType` as the discriminator property, GBP account payloads can no longer reliably validate/resolve to the correct schema variant.

This also drops the sort code/account number constraints (pattern/length), so invalid routing values will now pass schema validation.

How can I resolve this? If you propose a fix, please make it concise.

50 changes: 50 additions & 0 deletions openapi/components/schemas/common/GbpBeneficiary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
type: object
required:
- fullName
properties:
fullName:
type: string
description: The full name of the beneficiary
birthDate:
type: string
description: The birth date of the beneficiary
nationality:
type: string
description: The nationality of the beneficiary
email:
type: string
description: The email of the beneficiary
phoneNumber:
type: string
description: The phone number of the beneficiary
registrationNumber:
type: string
description: The registration number of the beneficiary
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
type: object
required:
- country
- line1
- postalCode
properties:
line1:
type: string
description: Address line 1
postalCode:
type: string
description: Postal code
country:
type: string
description: Country code
line2:
type: string
description: Address line 2
city:
type: string
description: City
state:
type: string
description: State or province
11 changes: 11 additions & 0 deletions openapi/components/schemas/common/HkdAccountInfo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
type: object
required:
- bankName
- accountNumber
properties:
bankName:
type: string
description: The bank name of the bank
accountNumber:
type: string
description: The account number of the bank
50 changes: 50 additions & 0 deletions openapi/components/schemas/common/HkdBeneficiary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
type: object
required:
- fullName
properties:
fullName:
type: string
description: The full name of the beneficiary
birthDate:
type: string
description: The birth date of the beneficiary
nationality:
type: string
description: The nationality of the beneficiary
email:
type: string
description: The email of the beneficiary
phoneNumber:
type: string
description: The phone number of the beneficiary
registrationNumber:
type: string
description: The registration number of the beneficiary
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
type: object
required:
- country
- line1
- postalCode
properties:
line1:
type: string
description: Address line 1
postalCode:
type: string
description: Postal code
country:
type: string
description: Country code
line2:
type: string
description: Address line 2
city:
type: string
description: City
state:
type: string
description: State or province
11 changes: 11 additions & 0 deletions openapi/components/schemas/common/IdrAccountInfo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
type: object
required:
- sortCode
- accountNumber
properties:
sortCode:
type: string
description: The sort code of the bank
accountNumber:
type: string
description: The account number of the bank
50 changes: 50 additions & 0 deletions openapi/components/schemas/common/IdrBeneficiary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
type: object
required:
- fullName
properties:
fullName:
type: string
description: The full name of the beneficiary
birthDate:
type: string
description: The birth date of the beneficiary
nationality:
type: string
description: The nationality of the beneficiary
email:
type: string
description: The email of the beneficiary
phoneNumber:
type: string
description: The phone number of the beneficiary
registrationNumber:
type: string
description: The registration number of the beneficiary
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
type: object
required:
- country
- line1
- postalCode
properties:
line1:
type: string
description: Address line 1
postalCode:
type: string
description: Postal code
country:
type: string
description: Country code
line2:
type: string
description: Address line 2
city:
type: string
description: City
state:
type: string
description: State or province
7 changes: 7 additions & 0 deletions openapi/components/schemas/common/InrAccountInfo.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
type: object
required:
- vpa
properties:
vpa:
type: string
description: The VPA of the bank
50 changes: 50 additions & 0 deletions openapi/components/schemas/common/InrBeneficiary.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
type: object
required:
- fullName
properties:
fullName:
type: string
description: The full name of the beneficiary
birthDate:
type: string
description: The birth date of the beneficiary
nationality:
type: string
description: The nationality of the beneficiary
email:
type: string
description: The email of the beneficiary
phoneNumber:
type: string
description: The phone number of the beneficiary
registrationNumber:
type: string
description: The registration number of the beneficiary
countryOfResidence:
type: string
description: The country of residence of the beneficiary
address:
type: object
required:
- country
- line1
- postalCode
properties:
line1:
type: string
description: Address line 1
postalCode:
type: string
description: Postal code
country:
type: string
description: Country code
line2:
type: string
description: Address line 2
city:
type: string
description: City
state:
type: string
description: State or province
Loading