BOLT 12 Offer test vectors#2682
Merged
valentinewallace merged 3 commits intolightningdevkit:mainfrom Nov 1, 2023
Merged
Conversation
Additional BOLT 12 tests specific to Offer were added, which will live in the offer module. Thus, it makes sense to move the bech32 tests to the parse module.
One discrepancy from the spec still needs to be resolved: https://github.com/lightning/bolts/pull/798/files#r1334851959
TheBlueMatt
approved these changes
Oct 29, 2023
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
I didn't bother to check that these match the BOLT PRs, but I'm just gonna assume they do.
valentinewallace
approved these changes
Nov 1, 2023
Contributor
|
Are there any outstanding test vectors from the spec left to add or are they all done now? |
Contributor
Author
None outstanding, but more are slated to be added to the spec for messages not yet covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include recently added spec test vectors for
Offerparsing. The previous test vectors only dealt with bech32 parsing.