-
Notifications
You must be signed in to change notification settings - Fork 436
Prefactor PaymentParameters for blinded recipients
#2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefactor PaymentParameters for blinded recipients
#2258
Conversation
f7d4237 to
215ea05
Compare
215ea05 to
aec3d4d
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01%
==========================================
Files 104 105 +1
Lines 51993 60983 +8990
Branches 51993 60983 +8990
==========================================
+ Hits 47616 55848 +8232
- Misses 4377 5135 +758
☔ View full report in Codecov by Sentry. |
aec3d4d to
0275873
Compare
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM.
Minor changes in preparation for supporting route blinding in PaymentParameters. In the next commit, we'll be moving more unblinded-payee-specific fields from the top level parameters into the clear enum variant.
1e3d7af to
0f823fb
Compare
0f823fb to
4729342
Compare
4729342 to
554c1fc
Compare
1298418 to
dca58c3
Compare
TheBlueMatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically lgtm, a few logging nits.
dca58c3 to
9d7a370
Compare
9d7a370 to
fb9983c
Compare
fb9983c to
a84e832
Compare
Since blinded payees don't have one
Since blinded payees don't have this.
Since blinded pay params won't have this value.
a84e832 to
d56672c
Compare
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid
PaymentParameterscan't be created.