Fixes corruption of memory datatypes caused by short circuit logic in modeMemory_t::slice
#727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corruption of the original memory's data type can occur when `this` is returned.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #727 +/- ##
============================================
Coverage 75.25% 75.25%
============================================
Files 297 297
Lines 19327 19328 +1
============================================
+ Hits 14544 14545 +1
Misses 4783 4783
|
kris-rowe
added a commit
that referenced
this pull request
Jan 24, 2024
… `modeMemory_t::slice` (#727)
kris-rowe
added a commit
that referenced
this pull request
Mar 12, 2024
… `modeMemory_t::slice` (#727)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #690