Skip to content

Conversation

@dmed256
Copy link
Member

@dmed256 dmed256 commented Jun 4, 2020

Description

Removes comment tokens from tokenContext_t to avoid parsing issues

@dmed256 dmed256 added bug Use this label when reporting bugs! parser labels Jun 4, 2020
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #358 into master will decrease coverage by 0.24%.
The diff coverage is 88.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   76.07%   75.82%   -0.25%     
==========================================
  Files         246      241       -5     
  Lines       17973    18253     +280     
==========================================
+ Hits        13673    13841     +168     
- Misses       4300     4412     +112     
Impacted Files Coverage Δ
src/lang/statementPeeker.cpp 94.44% <ø> (-0.13%) ⬇️
src/lang/tokenContext.cpp 79.85% <76.36%> (+0.17%) ⬆️
src/lang/parser.cpp 87.11% <98.30%> (+0.03%) ⬆️
src/c/types.cpp 79.59% <100.00%> (+0.09%) ⬆️
include/occa/tools/cli.tpp 0.00% <0.00%> (-95.66%) ⬇️
include/occa/lang/type/type.hpp 0.00% <0.00%> (-75.00%) ⬇️
include/occa/tools/json.tpp 26.19% <0.00%> (-73.81%) ⬇️
include/occa/io/output.tpp 0.00% <0.00%> (-50.00%) ⬇️
include/occa/lang/statement/statement.hpp 0.00% <0.00%> (-50.00%) ⬇️
include/occa/tools/vector.hpp 80.00% <0.00%> (-20.00%) ⬇️
... and 25 more

@dmed256 dmed256 merged commit 295eba6 into master Jun 4, 2020
@dmed256 dmed256 deleted the lang/add-comments-to-tokencontext branch June 4, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Use this label when reporting bugs! parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants