v0.3.0-wip

[elf-pavlik]

• preserve data type #5 preserve data types
• Some IRIs not read correctly #4 some IRIs not read correctly
• support literals with language tags #11 support language tags
• update to LevelGraph 0.7.1
• update other dependencies
• move from " to '
• move away from comma first

[mcollina]

You should load it this way:

  , N3Util = require("n3").Util;

Ref: https://github.com/RubenVerborgh/N3.js#utility

[elf-pavlik]

I thought that if I do it this way browserify will only bundle up this one file instead of all the n3... haven't really checked if I made correct assumption :)

[RubenVerborgh]

What you say about browserify is true; however, N3.js only commits to the interface offered by require('n3').
This means that, in theory, the file N3Util.js could be moved or replaced, whereas N3.Util remains.
So I leave it to you to decide this.

[elf-pavlik]

@RubenVerborgh that makes sense!
If we can assume that you won't make such changes without bumping MINOR version of your package, leaving it this way seems pretty safe?

[RubenVerborgh]

Well, actually I could make such changes as I don't officially support the n3/lib/N3Util API, but that would be highly unlikely, so don't worry 😄
However, would you care to add a small comment to that line so it does not get copied by others inadvertently?

[mcollina]

It's 👍 for me.

Please fix that require and we can merge. I'll release this as 0.3.0.
Do you plan to do some more work for the next release?

[elf-pavlik]

after i fix directly relevant #11 and update readme with information on how we store literals you can go ahead and release 0.3.0 📦

oh, i also should add tests for fix of #4 !

[elf-pavlik]

@RubenVerborgh good point with adding comment! i even did it just before you explicitly requested it 😄

[elf-pavlik]

@mcollina if you agree with keeping this way of requiring N3Util I will merge it after adding tests for #4

in case you have missed my last few exchanges about it with Ruben please just check your mail notifications since those line comments disappeared from here after my last push!

[elf-pavlik]

ready!

just added few tests for IRIs so after merging we can also close #4

i'll prepare another PR for #11 and then we can release it as 0.3.0 📦

[mcollina]

👍 for me. You can merge here or in a v0.3.0-wip thing.
As we are breaking the API, we can already base it on top of levelgraph v0.7, which is ready and big (levelgraph/levelgraph#42)

[elf-pavlik]

I've updated levelgraph to 0.7.0 and happily moved from " to ' 👯

[elf-pavlik]

@mcollina I had search_spec failing when trying to update level-test, maybe you could take a look at it?

[mcollina]

It triggers a bug in SortJoinStream that I introduced by the refactoring in 0.7.0, I'm looking at it.

[mcollina]

With { joinAlgorithm: 'simple' } works fine, so there is a regression in the fastest merge sort implementation.

[elf-pavlik]

I think we can merge this one & release 0.3.0 after you resolve this issue which came up with level-test 😄

[mcollina]

Ahum, I need to release levelgraph 0.7.1 first with the fix for this issue.
It's much more complicated, but I nailed it.

I have to write a couple more unit tests for LevelGraph and redo the fix there. Hopefully tomorrow!

[elf-pavlik]

no rush, i'll just start now looking at getting this extension to work in a web browser!

[mcollina]

it should be fixed in levelgraph/levelgraph#51, please confirm!

[elf-pavlik]

ready for me! can you just check out 731a027 before merging and releasing new minor version?