Fix some minor SDL2 paper cuts#831
Merged
cxxxr merged 6 commits intolem-project:mainfrom Jul 15, 2023
Merged
Conversation
This adds a new method to the interface so that an implementation can choose to add a title to the titlebar in the OS-gui-sense.
This adds an implementation to SDL2 to allow the user to safely set and get the title of the gui window. Note that we need to wrap this call in `sdl2:in-main-thread` due to some desktop environments requiring gui changes to be called in the main thread, most famously macOS.
This adds a new method to the interface so that an implementation can add a fullscreen feature.
This adds an implementation to SDL2 to allow the user to safely set the fullscreen of a gui window. Note that we need to wrap this call in `sdl2:in-main-thread` due to some desktop environments requiring gui changes to be called in the main thread, most famously macOS.
This allows the user to specify whether or not to use the native fullscreen in macOS. Default is nil.
This adds a new module for frame commands with an initial command for toggling fullscreen.
cxxxr
reviewed
Jul 15, 2023
Member
cxxxr
left a comment
cxxxr
left a comment
There was a problem hiding this comment.
Thank you for the nice PR.
I have checked it on windows and mac and it seems to be working properly.
This was referenced Jul 16, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches add the ability to get/set the gui window's title along with toggling fullscreen.