Closed
Conversation
theFeu
reviewed
Jan 9, 2018
| } elseif ($args[0] == "list" && count($args[2]) == 2) { | ||
| return $this->lib_mix([ $args[0], $args[1], [$black, $args[2][0], $args[2][1]] ]); | ||
| } else { | ||
| $this->throwError("tint expects (color, weight)"); |
There was a problem hiding this comment.
"shade expects (color, weight)"
would probably be a better message ;)
but thanks a lot for saving me some time writing this :)
Collaborator
There was a problem hiding this comment.
Thanks, I've fixed this as part of the merge.
|
Could you create a pull request for MarcusSchwarz/lesserphp instead? |
Krinkle
added
match-upstream
pr: enhancement
pending-feedback
and removed
pending-feedback
labels
splitbrain
pushed a commit
to splitbrain/lesserphp
that referenced
this pull request
Jan 27, 2024
See <http://lesscss.org/functions/#color-operations-tint> and <http://lesscss.org/functions/#color-operations-shade>. Closes leafo#634. > cherry picked from ca-dsgn/lessphp@b63a8c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented functions "tint" and "shade".
See http://lesscss.org/functions/#color-operations-tint and http://lesscss.org/functions/#color-operations-shade