Test demonstrating issue with imports and variables#539
Closed
FMCorz wants to merge 1 commit intoleafo:masterfrom
FMCorz:TestImportVariables
Closed
Test demonstrating issue with imports and variables#539FMCorz wants to merge 1 commit intoleafo:masterfrom FMCorz:TestImportVariables
FMCorz wants to merge 1 commit intoleafo:masterfrom
FMCorz:TestImportVariables
Conversation
Contributor
|
This could be closed. |
splitbrain
added a commit
to splitbrain-forks/lesserphp
that referenced
this pull request
May 22, 2018
The leafo#539 PR contained a trailing white space in the output test file which made the test always fail.
MarcusSchwarz
pushed a commit
to MarcusSchwarz/lesserphp
that referenced
this pull request
May 28, 2018
* Test demonstrating issue with imports and variables * removed trailing white space The leafo#539 PR contained a trailing white space in the output test file which made the test always fail. * failing test for dynamic imports When dynamically importing a file (using a variable for the import path) the parser will throw an exception about the variable not being defined, even though it clearly is. This problem was first reported at dokuwiki/dokuwiki#2260 * fix problem with variable import paths This fixes the problem described at dokuwiki/dokuwiki#2260 but may not be the most elegant solution.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New test demonstrating the issue explained in #506.