`max_connections` does nothing

[pranjalv123]

Describe the bug
max_connections in new_feature_store and new_big_segment_store in ldclient/integrations/__init__.py is unused. This means you would have to pass max_connections inside of redis_opts if you want to limit the max connections.

I believe DEFAULT_MAX_CONNECTIONS is also unused, so the number of redis connections is the redis ConnectionPool default of 2**31.

Expected behavior

I would expect this to limit the number of maximum connections; however, this may be a dangerous change to make as users are probably relying on the unbounded maximum connection behavior.

SDK version

This is present in the latest release on github (9.13.1).

Language version, developer tools
Python

[keelerm84]

Thank you for raising this issue @pranjalv123.

Looking at the history of this repository, this parameter was originally deprecated and scheduled for removal in the v8 release. While the implementation and documentation were updated, the commit at the time failed to actually remove it from the method signature. 🤦🏼 I suspect some bad merge conflict where this went unnoticed.

I will work on making an update to address this issue, and will notify you here when I'm done.