Merged
Conversation
owal7428
force-pushed
the
feature/shot-noise
branch
from
9865760 to
6008afb
Compare
thibaudteil
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds shot noise to images using a Gaussian approximation of a Poisson distribution with lambda equal to number of electrons generated from the sensor pixel. This approximation is valid because at the point at which it breaks down (around <= 10 electrons), the noise is below 1 color level (1/255 for 8-bit pixel depth) for typical FWC values, so the difference between Gaussian and Poisson is practically imperceptible. Shot noise can be enabled or disabled from the protobuf.Verification
Images were verified visually by comparing the images with and without shot noise as well as images containing just the noise itself. Testing was also done on Windows and Mac.Documentation
None.Future work
Other noise corruption effects such as dark current.