Skip to content

refactor(web): remove unused type alias VoiceLanguageKey#30694

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fghpdf:fix/remove-unused-type-alias
Jan 7, 2026
Merged

refactor(web): remove unused type alias VoiceLanguageKey#30694
crazywoola merged 1 commit intolanggenius:mainfrom
fghpdf:fix/remove-unused-type-alias

Conversation

@fghpdf
Copy link
Contributor

@fghpdf fghpdf commented Jan 7, 2026

Summary

Remove unused type alias VoiceLanguageKey and its unused import I18nKeysWithPrefix from param-config-content.tsx.

Why

  • The type alias VoiceLanguageKey was declared but never used
  • Detected by npx oxlint
  • Clean up codebase by removing unused code

Test plan

  • pnpm lint:fix passes
  • pnpm type-check:tsgo passes
  • All 9449 frontend tests pass

Part of #25189

Remove unused type alias VoiceLanguageKey and its unused import I18nKeysWithPrefix
from param-config-content.tsx.

Part of langgenius#25189
Copilot AI review requested due to automatic review settings January 7, 2026 09:02
@fghpdf fghpdf requested review from iamjoel and zxhlyh as code owners January 7, 2026 09:02
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 7, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fghpdf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the web application by removing an unused type alias, VoiceLanguageKey, and its corresponding import, I18nKeysWithPrefix, from the param-config-content.tsx file. This targeted cleanup improves code hygiene and reduces unnecessary declarations, ensuring the codebase remains efficient and easier to maintain without introducing any functional changes.

Highlights

  • Unused Type Alias Removal: The VoiceLanguageKey type alias, which was declared but never utilized, has been successfully removed from param-config-content.tsx.
  • Unused Import Cleanup: The I18nKeysWithPrefix import, solely used by the now-removed VoiceLanguageKey, has also been eliminated, further streamlining the file.
  • Codebase Hygiene: This change contributes to overall codebase cleanliness and maintainability by removing dead code, as identified by npx oxlint.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the unused type alias VoiceLanguageKey and its corresponding import from param-config-content.tsx. This change improves code clarity and maintainability by eliminating dead code. The refactoring is straightforward and has been implemented correctly. No issues were found.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused type alias VoiceLanguageKey and its unused import I18nKeysWithPrefix from the text-to-speech parameter configuration component. The cleanup was identified by oxlint and improves code maintainability by removing dead code.

Key Changes

  • Removed unused type import I18nKeysWithPrefix from @/types/i18n
  • Removed unused type alias VoiceLanguageKey definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2026
@crazywoola crazywoola merged commit d8a0291 into langgenius:main Jan 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants