refactor(web): remove unused type alias VoiceLanguageKey#30694
refactor(web): remove unused type alias VoiceLanguageKey#30694crazywoola merged 1 commit intolanggenius:mainfrom
Conversation
Remove unused type alias VoiceLanguageKey and its unused import I18nKeysWithPrefix from param-config-content.tsx. Part of langgenius#25189
Summary of ChangesHello @fghpdf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the web application by removing an unused type alias, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unused type alias VoiceLanguageKey and its corresponding import from param-config-content.tsx. This change improves code clarity and maintainability by eliminating dead code. The refactoring is straightforward and has been implemented correctly. No issues were found.
There was a problem hiding this comment.
Pull request overview
This PR removes the unused type alias VoiceLanguageKey and its unused import I18nKeysWithPrefix from the text-to-speech parameter configuration component. The cleanup was identified by oxlint and improves code maintainability by removing dead code.
Key Changes
- Removed unused type import
I18nKeysWithPrefixfrom@/types/i18n - Removed unused type alias
VoiceLanguageKeydefinition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Remove unused type alias
VoiceLanguageKeyand its unused importI18nKeysWithPrefixfromparam-config-content.tsx.Why
VoiceLanguageKeywas declared but never usednpx oxlintTest plan
pnpm lint:fixpassespnpm type-check:tsgopassesPart of #25189