Expose connectors in GET /info Features and add IsPluginEnabled extension#5527
Open
nortonandreev wants to merge 1 commit intomasterfrom
Open
Expose connectors in GET /info Features and add IsPluginEnabled extension#5527nortonandreev wants to merge 1 commit intomasterfrom
connectors in GET /info Features and add IsPluginEnabled extension#5527nortonandreev wants to merge 1 commit intomasterfrom
Conversation
…sion - Add 'connectors' to the Features dictionary in /info when Connectors plugin is enabled - Add ClusterVNodeOptions.IsPluginEnabled(name) extension in Core for consistent plugin checks - Use IsPluginEnabled in PluginsService and in ClusterVNode for the connectors feature flag Co-authored-by: Cursor <cursoragent@cursor.com>
nortonandreev
changed the title
connectors in GET /info Features and add IsPluginEnabled extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
connectorsentry to theFeaturesobject returned by GET /info when the Connectors plugin is enabled, so clients can detect connector support. IntroducesClusterVNodeOptions.IsPluginEnabled(name)in Core and uses it for this flag and inPluginsService.Note:
PluginsService.IsPluginEnabledis now case-insensitive.This won't be immediately useful since it only applies to new deployments running the latest/upcoming version. In the meantime, we can detect connector support by checking for error code 12 (Unimplemented) from the connectors list endpoint, so that's what we'll use for now. That said, I'd prefer to eventually rely on this flag instead — making requests that we expect to fail isn't ideal when there's a cleaner way to check for capability.