Updated location of configmap-v1.json to a reachable destination#4424
Merged
liamfallon merged 6 commits intomainfrom Mar 5, 2026
Merged
Updated location of configmap-v1.json to a reachable destination#4424liamfallon merged 6 commits intomainfrom
liamfallon merged 6 commits intomainfrom
Conversation
Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>
ciaranjohnston
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
bot
added
the
size:XS
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the e2e expected execution script for the fn-eval privilege-options mount scenario to download the Kubernetes ConfigMap schema from a different (reachable) URL before running kpt fn eval.
Changes:
- Switch schema download URL for
configmap-v1.jsontoraw.githubusercontent.com/yannh/kubernetes-json-schema.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Adding new logo Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> --------- Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
* rename UpstreamLock type to Locator, add generic locator type Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> * add deprecated type alias Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> * fix additional copilot comments, fix schema generation Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> * strip kubebuilder annos Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> --------- Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
…ote the output directory to avoid word-splitting Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>
dosubot
bot
added
size:XXL
efiacor
approved these changes
Mar 5, 2026
liamfallon
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.