feat: drop node < 18, es module, update testing to use vitest#36
feat: drop node < 18, es module, update testing to use vitest#36knownasilya wants to merge 9 commits intomasterfrom
Conversation
BREAKING CHANGE: use es module, drop Node < 18
SBoudrias
left a comment
There was a problem hiding this comment.
Changes LGTM
I'll just share Inquirer (the @inquirer/* at least) won't be able to upgrade to this version since I kept the packages dual cjs/esm. Going esm only caused too much pain on the users; and way too many folks didn't know how to handle that (turning into a huge support load on our issue tracker.)
|
@SBoudrias I was wondering on the dual version and if it was needed, this answers my question. Any suggestions on how to do the dual variant? |
|
I found it not too complicated to put together with Typescript (if you don't mind using it for cli-width.) Not sure how I'd approach it just with raw JS. But you can see I generate 2 tsconfig ( The extension issue maybe could be fixed if I didn't use Hope this help - esm/cjs is far from easy today unfortunately 😞 |
BREAKING CHANGE: drop node < 18, es modules and cjs
Not that big of a change, mostly lockfile bloating the numbers