RandomChoice 2 policy wasn't random when the number of targets is 2 (with equal weight)

[dprotaso]

Fixes: #14011
Fixes: #12593

Proposed Changes

• Activator Random Choice 2 Policy will now pick randomly between two targets that have equal weight

Release Note

Fix activator load balancing when using unbounded concurrency and when you have two instances of a revision

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6020cec) 86.21% compared to head (b4fb149) 86.23%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14028      +/-   ##
==========================================
+ Coverage   86.21%   86.23%   +0.02%     
==========================================
  Files         199      199              
  Lines       14759    14767       +8     
==========================================
+ Hits        12724    12734      +10     
+ Misses       1733     1731       -2     
  Partials      302      302              

Impacted Files	Coverage Δ
pkg/activator/net/lb_policy.go	96.72% <100.00%> (+0.23%)	⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ReToCode]

Nice find!

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ReToCode]

/retest

[dprotaso]

/cherry-pick release-1.10
/cherry-pick release-1.9

[knative-prow-robot]

@dprotaso: new pull request created: #14052

Details

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

/cherry-pick release-1.9

[knative-prow-robot]

@dprotaso: new pull request created: #14053

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.