fix 289 addDataEntity no longer supports toHasPart parameter#298
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Previously, Dataset entities were just deserialized into DataEntity instances, making casting impossible. Now we can cast them or retrieve them, and make advantage of their specializations.
0cfcd64 to
8ced011
Compare
Pull Request Test Coverage Report for Build #568Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…der version and the crate version.
ba7fae0 to
a741dc4
Compare
We still use it internally, but I plan to replace it at some point in future. We should be able to generate at least basically valid entities from external providers. And if not we can still work around this with a custom, private subclass of RoCrate.
PR for #289, with plan to do a release candidate before closing the issue.
Two solution approaches that I'd like to publish as a release candidate: