Skip to content

Fix invalid context check warnings#188

Merged
Pfeil merged 3 commits intomainfrom
fix-#6-reserved-keywords-warnings
Sep 12, 2024
Merged

Fix invalid context check warnings#188
Pfeil merged 3 commits intomainfrom
fix-#6-reserved-keywords-warnings

Conversation

@Pfeil
Copy link
Member

@Pfeil Pfeil commented Sep 6, 2024

  • Handle @id as type as if the id would be the type.
  • Consider @json to be a type which does not need context. Consider making a list in case we discover more such cases later on.
  • make sure something like https://schema.org/Dataset is handled properly as a type and not as a suffix of a type (see below). We might need some proper types abstraction for this.
  • tests missing

@Pfeil Pfeil linked an issue Sep 6, 2024 that may be closed by this pull request
@Pfeil Pfeil marked this pull request as ready for review September 6, 2024 12:58
@coveralls
Copy link

coveralls commented Sep 6, 2024

Pull Request Test Coverage Report for Build #252

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.687%

Totals Coverage Status
Change from base Build #249: 0.04%
Covered Lines: 1597
Relevant Lines: 1761

💛 - Coveralls

@Pfeil Pfeil force-pushed the fix-#6-reserved-keywords-warnings branch from a9985d0 to c8d89de Compare September 12, 2024 12:51
@Pfeil Pfeil merged commit 5681afb into main Sep 12, 2024
@Pfeil Pfeil deleted the fix-#6-reserved-keywords-warnings branch September 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reserved keywords cause warnings

2 participants