Allows to specify a domain when deleting a cookie.#31
Merged
hishamhm merged 2 commits intokeplerproject:masterfrom Mar 21, 2014
Merged
Allows to specify a domain when deleting a cookie.#31hishamhm merged 2 commits intokeplerproject:masterfrom
hishamhm merged 2 commits intokeplerproject:masterfrom
Conversation
When a cookie has been set with a given domain (i.e. domain="example.com"), subsequent attempts to delete it will be ignored by the browser if the same domain is not provided. So a 'domain' parameter is added to the 'delete_cookie' method in order to be able to delete those cookies.
Member
|
Any compatibility concerns about merging this one? |
Member
Author
|
None. This is a new optional parameter. If not present, nothing will change in the Set-Cookie responses as they are now. We may want a few days in case anyone else wants to chime in. |
Member
Author
|
Well, a few days have passed. Should we merge this? |
hishamhm
added a commit
that referenced
this pull request
Mar 21, 2014
Allows to specify a domain when deleting a cookie.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cookie has been set with a given domain (i.e. domain="example.com"), subsequent attempts to delete it will be ignored by the browser if the same domain is not provided.
So a 'domain' parameter is added to the 'delete_cookie' method in order to be able to delete those cookies.