Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the 2D simplex noise implementation for improved clarity and performance, particularly in how gradients are handled and accessed. The main changes include switching the gradient representation from packed integers to float arrays, updating the initialization logic, and simplifying the noise calculation code. Benchmark results in the
README.mdhave also been updated to reflect new performance metrics.Gradient representation and initialization:
gradarray from storing packeduint16values to storing[2]float32arrays, making the gradient vectors easier to use and understand.init()to unpack and store gradients directly as float pairs, improving clarity and reducing bit manipulation.Noise computation simplification:
Noise2function to use float values for simplex triangle selection and offsets, streamlining the calculation and reducing unnecessary type conversions.dot2Dfunction and improving performance.Benchmark update:
README.mdto show new performance results with more descriptive labels, reflecting the impact of the code changes.