Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
simplex.goimplementation to remove unsafe pointer usage, replacing it with safer, direct indexing into arrays. Additionally, it simplifies the benchmarking logic inbench/main.goby fixing the input size for noise tests. These changes improve code safety, readability, and maintainability.Simplex noise implementation refactor
unsafe.Pointerand related pointer arithmetic insimplex.go, eliminating thepPermandpGradvariables and associated functions (permutationsAtandgradientAt). All array accesses are now done via safe indexing. [1] [2] [3]Noise2function to use direct array indexing for permutation and gradient lookup, with explicit bounds checks for the compiler.Benchmark logic simplification
bench/main.goto use a fixed input size (size = 1000) for all shapes, instead of iterating over multiple sizes.bench/main.goby removing an unnecessary closing brace.