Update create-alias.rst#1
Merged
juneb merged 2 commits intojuneb:kms-examplesfrom Jun 14, 2018
phillisf:patch-1
Merged
Conversation
Modified explanation text. Removed 'alias/' from sentence beginning "Alias names must begin with..." to line up with wording in our documentation [1]. Removed the reference to the Decrypt API operation as this is not related to modifying an alias [2]. [1] https://docs.aws.amazon.com/awscloudtrail/latest/userguide/KMS-key-naming-requirements.html [2] https://docs.aws.amazon.com/kms/latest/APIReference/API_Decrypt.html
Owner
|
Thanks for catching that cut/paste error. I used it when I was learning to add links in RST. Let's fix that language. We can't say "alias names must begin with 'alias/'" and then say "Alias names cannot begin with 'aws.' Of course they can't. They have to begin with 'alias/'. I suggest the following: When specifying an alias in the CLI, type This sentence appears in a few places, so I'll be sure to change all of them. |
juneb
approved these changes
Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified explanation text.
Removed 'alias/' from sentence beginning "Alias names must begin with..." to line up with wording in our documentation [1].
Removed the reference to the Decrypt API operation as this is not related to modifying an alias [2].
[1] https://docs.aws.amazon.com/awscloudtrail/latest/userguide/KMS-key-naming-requirements.html
[2] https://docs.aws.amazon.com/kms/latest/APIReference/API_Decrypt.html