Fixes for safe_level, trim_mode argument of ERB.new is deprecated warning #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
So, we are running many versions of Ruby (as JRuby versions), and we probably need to support more argument lists than the new one. I suggest adding a conditional, checking that the keyword argument way of doing things is available. |
|
May be worth as a separate PR dropping some of the older jruby versions as unsupported from CI. |
| end | ||
|
|
||
| after(:all) { ENV.clear; ENV.update @@_env } | ||
| # after(:all) { ENV.clear; ENV.update @@_env } |
There was a problem hiding this comment.
Does this really need to be commented out; vs just replaced?
kares
requested changes
Jul 1, 2025
Member
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
as mentioned already, erb = ERB.new(File.read(file), trim_mode: '-') looks good.
the rest (dotenv) isn't really needed in a library and should be removed. 🙏
Contributor
|
This was subsequently fixed in #559 so can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/workspaces/warbler/lib/warbler/jar.rb:288: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/workspaces/warbler/lib/warbler/jar.rb:288: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.