Skip to content

Fix jlabel parser/serializer bugs#25

Merged
phenylshima merged 5 commits intomainfrom
reversed-logic
Feb 6, 2024
Merged

Fix jlabel parser/serializer bugs#25
phenylshima merged 5 commits intomainfrom
reversed-logic

Conversation

@phenylshima
Copy link
Copy Markdown
Member

@phenylshima phenylshima commented Feb 5, 2024

ref: jpreprocess/jpreprocess#219

  • E5/G5の論理が逆になっていたので,直しました.
  • B2,B3,C2,C3,D2,D3は1桁で出力する必要がありますので,これも直しました.

@phenylshima phenylshima requested a review from cm-ayf February 5, 2024 09:06
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5ef2d6) 91.43% compared to head (c072a5d) 93.28%.

❗ Current head c072a5d differs from pull request most recent head 11b29a8. Consider uploading reports for the commit 11b29a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   91.43%   93.28%   +1.84%     
==========================================
  Files           8        8              
  Lines         981     1013      +32     
==========================================
+ Hits          897      945      +48     
+ Misses         84       68      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phenylshima phenylshima changed the title Fix reversed logic of e5/g5 Fix jlabel parser/serializer bugs Feb 5, 2024
@phenylshima phenylshima merged commit 8ce3797 into main Feb 6, 2024
@phenylshima phenylshima deleted the reversed-logic branch February 6, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant