This repository was archived by the owner on Mar 10, 2021. It is now read-only.
Conversation
feat: Customizable Wave hertz - Users can change wave speed manually; Any value [0,1]. chore: Upgraded Gradle plugin version to 4.11 and Gradle version to 6.5 - "Support for builds using Gradle versions older than 2.6 was removed in tooling API version 5.0. You are currently using Gradle version 2.2. You should upgrade your Gradle build to use Gradle 2.6 or later."
Kalaiz
added a commit
to Kalaiz/WaveView
that referenced
this pull request
Feb 21, 2021
feat: Fill to brim - Current implementation does not give an option to fill the view till the brim, hence, I added a feature to allow users to let the view fill to the brim on their discretion via the newly created boolean attribute: `fill_to_brim` chore: Includes Gradle update done in john990#25 chore: README update - Badge fix from john990#25 and code update based on this feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of using custom hz value for wave:
Users simply have to set the newly altered attribute
wave_hz:Upgraded Gradle plugin version to 4.11 and Gradle version to 6.5
While running on Android Studio IDE 4.1.1,a prompt to upgrade Gradle appeared"Support for builds using Gradle versions older than 2.6 was removed in tooling API version 5.0. You are currently using Gradle version 2.2. You should upgrade your Gradle build to use Gradle 2.6 or later."
Updated and fixed minor issue regarding badge in README:
Added public getter for progess (A getter for the progress would be very useful #21)