Merged
Conversation
Changes to movie player affecting lots of things. This lets it run but the first frame functionality is no good the second time a movie file is presented, and I haven't tested if it mutes successfully without direct intervention.
Python 3.8 isn't working b/c it can't install ffpyplayer for some reason. This is not relevant to function so I'm just going to have it test on 3.10.
For some reason frameIndex no longer works, but PTS should still be able to identify when the seek has not yet reached the appropriate frame.
Found a solution for extracting the first frame that is even more fragile and kludgy, but functional. Need to test with audio stimuli to see if it causes chirps on load (it might).
Slower load time but cleaner first frame loading. However there is a slight problem on the first play in 2025.2 where there is a short (~50ms) delay on the very first play that causes a flicker...need to figure out how to test for that.
Version-flexible variables are only helpful if you use them.
Added a specific workaround for the first-playback first-frame black-flicker issue in 2025.2+. Also tested with sound-containing movies and all solutions working well. A BR has been filed for that issue in particular at PsychoPy, so hopefully it will get fixed soon.
Attention getters also need the first frame extraction, and now that it's modularized, it's easier to just call that function. Testing being blocked by another bug in getting the movie in the builder, but that will be its own update.
Adding a movie-based attention-getter was crashing because apparently size is no longer an optional argument.
Updating readme with some new developments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to in-person movie playback for 2025.2+ and a related builder bug.