add compatible-mode for opensearch#1690
Conversation
|
Before moving forward I would like to better understand your situation. Can you please share the output of |
This is a managed service that we got so turning the compatible mode off is a no go |
|
Thanks for providing that. Ideally I'd prefer a solution that let the user force ElastAlert 2 to use a specific version, instead of reading it from the cluster. That would give us similar flexibility for the future, where-as this compatibility mode flag would be somewhat specific to this situation. Please try inserting the following lines of code at the top of the util.py::get_version_from_cluster_info() method: And then rerun with that environment variable set to an 8.x version? If that works for you I'd like to go with that approach instead. |
|
I have added also a testcase since this approach was easier to test Edit: Verifiy it now and works, set the env |
|
Sorry for the delay. This PR is looking good. The docs (probably the docs/recipes/faq.rst) and changelog still need updated, however. |
|
I'd like to publish a new release soon so I wanted to see if you'll be able to push the remaining changes for this. I would expect it should only take a few minutes of your time. Thanks. |
|
Added the docs now, sorry for delay but I forgot about this |
Description
Add compatible-mode for when opensearch is set with compatible-mode based on discussion #1507
Checklist
make test-dockerwith my changes.Questions or Comments
I can add documentation and changelog if this PR is something you want merged, about the unit test i'm not sure where it would put it, also the naming on the arg can be changed to something better.