[FIXED JENKINS-23995] Set context for GH status

[KostyaSha]

supersede #47

[KostyaSha]

@janpapenbrock please test this hpi (press green checkbox and then click on "module builds")

[janpapenbrock]

Thanks very much for your effort. Still have a similar result, but the names have changed: https://raw.githubusercontent.com/janpapenbrock/github-plugin-test/master/3-notifications.png

While we are at it, I have a probem with getting the SHA1 to be set correctly in downstream builds - I have to clone it again although it was cloned upstream. This is probably a different issue, but its quite near in the code I guess. Should be this https://github.com/KostyaSha/github-plugin/blob/JENKINS-23995/src/main/java/com/cloudbees/jenkins/GitHubCommitNotifier.java#L102

Maybe this is related to the problem seen here?!?

[KostyaSha]

@janpapenbrock have you added new commit to branch where you testing statuses?

[janpapenbrock]

Yes, I did.

[janpapenbrock]

The Github API documentation says at https://developer.github.com/v3/repos/statuses/#create-a-status:

context string A string label to differentiate this status from the status of other systems. Default: "default"

So maybe this issue is related to the API implementation?

[KostyaSha]

@janpapenbrock stop guessing ;)
Status is set multiple times, i trusted initial PR code. Now should work right. Wait PR build results and test new hpi.

[janpapenbrock]

Great thanks ;)

[KostyaSha]

PR builds fixed, new hpi is available

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[janpapenbrock]

Success! :)

https://github.com/janpapenbrock/github-plugin-test/blob/master/4-success.png

Thank you!

[KostyaSha]

Cool, need +1 from some other dev and will merge.

[oleg-nenashev]

Any reasons to change the DisplayName to the project's full name. In such cases the status info will lose the information about the build.

[KostyaSha]

No, where this info displayed?

[KostyaSha]

Fixed and tested, result is here KostyaSha/test-repo#20

[KostyaSha]

@kohsuke @oleg-nenashev i will merge and release this state if i will get no replies in the next day.