[JENKINS-62097] GitHubPluginConfig.hookSecretConfig → hookSecretConfigs#229
Merged
KostyaSha merged 2 commits intojenkinsci:masterfrom May 10, 2020
Merged
Conversation
KostyaSha
reviewed
May 1, 2020
| : new HookSecretConfig(null); | ||
| } | ||
|
|
||
| @DataBoundSetter |
Member
There was a problem hiding this comment.
will it break existing caas configs?
Member
Author
There was a problem hiding this comment.
Not sure specifically how CasC works here. In general it does not guarantee backward compatibility even when settings XML is compatible. Out of scope for the design.
Member
There was a problem hiding this comment.
it would be bad to break casc users, such change would require some version and compat hpi marker...
Member
Author
There was a problem hiding this comment.
compatibleSinceVersion shows up in the GUI, not useful for CasC users.
In general when updating core/plugins with CasC you may need to make adjustments to YAML to match. AFAIK you get a straightforward error message otherwise so it is pretty obvious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amends #134. JENKINS-62097
This change is