[JENKINS-48139] Support ignoring push events from certain github users (ie a Jenkins user)#182
[JENKINS-48139] Support ignoring push events from certain github users (ie a Jenkins user)#182dbsanfte wants to merge 4 commits intojenkinsci:masterfrom
Conversation
…s (ie, the Jenkins user itself)
|
And that wouldn't work like you expect, triggering decision should be in trigger and not in incoming hooks. Either you will get in any case build for this user from trigger run. |
|
This is not a global story. All decisions should be delegated to job level |
|
Happy to make changes, but for a feature that should have been in the plugin from the get-go, beggars shouldn't be so choosy. Is it possible to delegate this to the trigger without there being a "failed build" in Jenkins? That's what the [ci skip] plugin results in. Events from ignored users shouldn't be recognized at all. |
|
Triggers has possibility to re-run checks, so any filtering on event processing will be ignored and you will get all builds. Filtering events is broken by design or may help only for pure triggers. But it wouldn't really help even for github push hooks trigger existing here because git polling will anyway find something different. Use advanced triggers that could handle everything correctly. Also github user is weird criteria, it doesn't exist after event gone. You should use git commit message/author filtering, not gh user. |
Support for ignoring push events from certain Github usernames. The obvious use case is ignoring push events from a Jenkins user and keeping them from re-triggering builds.
Tests + help files.
This change is