Manually entered repository source#131
Conversation
32dc5fb to
4ae71ca
Compare
| @@ -0,0 +1,3 @@ | |||
| <div> | |||
| A GitHub repository URL. | |||
| </div> No newline at end of file | |||
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@KostyaSha added the missing newlines |
|
Please add a little unit test |
|
src/main/java/org/jenkinsci/plugins/github/status/sources/ManuallyEnteredRepositorySource.java, line 41 [r2] (raw file):
logger can use formatting to avoid string concatenation via + Comments from Reviewable |
|
Reviewed 1 of 4 files at r1, 3 of 3 files at r2. Comments from Reviewable |
|
I have added a test when url cannot be converted into a repository name. However adding more coverage looks complicated because would need Jenkins rule and a valid connection to GitHub to resolve to a GHRepository. |
@reviewbybees
Allows to enter manually a repository to notify.
This is useful when you are working with a pipeline cloning multiple repositories and you want to notify only one of them on a specific SHA.
This change is