Skip to content

Create NOTICE.md#130

Merged
lanwen merged 2 commits intomasterfrom
notice
Jul 20, 2016
Merged

Create NOTICE.md#130
lanwen merged 2 commits intomasterfrom
notice

Conversation

@lanwen
Copy link
Member

@lanwen lanwen commented Jul 20, 2016

This change is Reviewable

@@ -0,0 +1,4 @@
## License notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in LICENSE.md imho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, LICENSE only for project license, all other in Notice file (take a look to apache projects)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? You can mention in LICENSE.md all information related to licenses.

@lanwen lanwen merged commit f6c4832 into master Jul 20, 2016
@lanwen lanwen deleted the notice branch July 20, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants