Windows registry name write default ?

[xbmlz]

I'm submitting a…

• bug report
• feature request
• other

Short description of the issue/suggestion:

Windows Registry Name is default

Steps to reproduce the issue/enhancement:

maven content

<registry>
    <entries>
        <entry>
            <key>HKCR:*\shell\${project.name}</key>
            <valueName>Icon</valueName>
            <valueType>REG_SZ</valueType>
            <valueData>{app}\{#MyAppExeName}</valueData>
        </entry>
        <entry>
            <key>HKCR:*\shell\${project.name}\command</key>
            <valueName>""</valueName>
            <valueType>REG_SZ</valueType>
            <valueData>{app}\{#MyAppExeName} %1</valueData>
        </entry>
    </entries>
</registry>

What is the expected behavior?

[Registry]
Root: HKCR; Subkey: "*\shell\JEditor"; ValueType: string; ValueName: "Icon"; ValueData: "{app}\{#MyAppExeName}"; Flags: uninsdeletevalue
Root: HKCR; Subkey: "*\shell\JEditor\command"; ValueType: string; ValueName: ""; ValueData: "{app}\{#MyAppExeName} %1"; Flags: uninsdeletevalue

source code is https://github.com/fvarrui/JavaPackager/blob/master/src/main/java/io/github/fvarrui/javapackager/packagers/GenerateSetup.java#L50

What is the current behavior?

[Registry]
Root: HKCR; Subkey: "*\shell\JEditor"; ValueType: string; ValueName: "Icon"; ValueData: "{app}\{#MyAppExeName}"; Flags: uninsdeletevalue
Root: HKCR; Subkey: "*\shell\JEditor\command"; ValueType: string; ValueName: """"; ValueData: "{app}\{#MyAppExeName} %1"; Flags: uninsdeletevalue

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement?

What is the motivation / use case for changing the behavior?

windows registry default name

Please tell us about your environment:

• JavaPackager version:
• OS version: windows 10
• JDK version: oracle-jdk-17
• Build tool:
  • Maven
  • Gradle

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

[xbmlz]

generate msi

[fvarrui]

Work in progress in branch issue-341.

[fvarrui]

registry.valueData and registry.valueName are no longer mandatory.

I've just released a SNAPSHOT version: 1.7.3-20230626.114901-9 (see how to use snapshot versions)

Please, test it and give some feedback.

Now working on MSI.

Thanks!

[fvarrui]

Just fixed for MSI generation.

Now you can test 1.7.3-20230627.004407-10 snapshot version, but you should do it this way:

<plugin>
  <groupId>io.github.fvarrui</groupId>
  <artifactId>javapackager</artifactId>
  <version>1.7.3-20230627.004407-10</version>
  <configuration>
	  <generateInstaller>true</generateInstaller>
	  [some other config options]
  </configuration>
  <executions>
	  <execution>
		  <id>windows-setup</id>
		  <phase>package</phase>
		  <goals>
			  <goal>package</goal>
		  </goals>
		  <configuration>
			  <platform>windows</platform>
			  <winConfig>
				  <generateSetup>true</generateSetup>
				  <generateMsi>false</generateMsi>
				  <registry>
					  <entries>
						  <entry>
							  <key>HKCR:*\shell\${project.name}</key>
							  <valueName>Icon</valueName>
							  <valueType>REG_SZ</valueType>
							  <valueData>{app}\{#MyAppExeName}</valueData>
						  </entry>
						  <entry>
							  <key>HKCR:*\shell\${project.name}\command</key>
							  <valueType>REG_SZ</valueType>
							  <valueData>{app}\{#MyAppExeName} %1</valueData>
						  </entry>
					  </entries>
				  </registry>
			  </winConfig>
		  </configuration>
	  </execution> 
	  <execution>
		  <id>windows-msi</id>
		  <phase>package</phase>
		  <goals>
			  <goal>package</goal>
		  </goals>
		  <configuration>
			  <platform>windows</platform>
			  <winConfig>
				  <generateSetup>false</generateSetup>
				  <generateMsi>true</generateMsi>
				  <registry>
					  <entries>
						  <entry>
							  <key>HKCR:*\shell\${project.name}</key>
							  <valueName>Icon</valueName>
							  <valueType>REG_SZ</valueType>
							  <valueData>[#EXEFILE]</valueData>
						  </entry>
						  <entry>
							  <key>HKCR:*\shell\${project.name}\command</key>
							  <valueType>REG_SZ</valueType>
							  <valueData>[#EXEFILE] %1</valueData>
						  </entry>
					  </entries>
				  </registry>
			  </winConfig>
		  </configuration>
	  </execution>
  </executions>
</plugin>

Note that valueName is not necessary for the default value and you need separate runs to generate the Setup installer on the one hand and the MSI on the other, since the way to set the registry entries for Inno Setup and for WiX Toolset are different.

[fvarrui]

Maybe we can define a kind of JP variables for installation path ({INSTALLDIR}) and installed EXE path ({EXEFILE}):

<registry>
	<entries>
		<entry>
			<key>HKCR:*\shell\${project.name}</key>
			<valueName>Icon</valueName>
			<valueType>REG_SZ</valueType>
			<valueData>{EXEFILE}</valueData>
		</entry>
		<entry>
			<key>HKCR:*\shell\${project.name}\command</key>
			<valueType>REG_SZ</valueType>
			<valueData>{EXEFILE} %1</valueData>
		</entry>
	</entries>
</registry>

Where, in this case, {EXEFILE} can be internally replaced with {app}\{#MyAppExeName} for Inno Setup and with [#EXEFILE] for WiX Toolset. This way you only need one execution.

[xbmlz]

Thank you very much. I will provide feedback during the test

[fvarrui]

Please, keep this issue open till you confirm it's fixed and released. Thanks!

[xbmlz]

I don't seem to be able to use the snapshot version

[fvarrui]

I'm not sure what's the problem, but javapackager-1.7.3-20230626.114901-9.jar is published. Maybe something is wrong for IntelliJ?

Did you try to build your app from the command line?