Open
Conversation
added 10 commits
November 12, 2025 12:39
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new beta DNS service called "ModDNS" to the IVPN account management system. The implementation follows the same pattern as the existing Mailx email aliasing service, adding internationalization support for both English and Spanish.
Changes:
- Added new DNS service (ModDNS) beta feature with registration and dashboard access flows
- Internationalized all user-facing text for both English and Spanish locales
- Updated account menu to accommodate additional service tabs with adjusted styling
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/themes/ivpn-v3/locales/en.json | Added English translations for ModDNS service descriptions, renamed menu item from "IVPN Account" to "Services", shortened "Account Settings" to "Settings" |
| src/themes/ivpn-v3/locales/es.json | Added Spanish translations for ModDNS service descriptions, updated menu items to match English changes |
| src/themes/ivpn-v3/assets/js/views/Account/Services/EmailService.vue | Internationalized hardcoded strings, updated capability field from has_mailx to has_mail, fixed field reference from email_service_deleted_at to mail_service_deleted_at |
| src/themes/ivpn-v3/assets/js/views/Account/Services/DnsService.vue | New Vue component for ModDNS service, mirrors EmailService structure with DNS-specific endpoints and identifiers |
| src/themes/ivpn-v3/assets/js/store/module_account.js | Added addDnsSubscription action, removed debug console.log from addEmailSubscription |
| src/themes/ivpn-v3/assets/js/router/index.js | Added three DNS service routes (base, /en/, /es/) with route definitions |
| src/themes/ivpn-v3/assets/js/components/AccountMenu.vue | Added DNS service tab, updated capability checks to has_mail/has_dns, adjusted menu styling with narrower max-width for better spacing |
| src/themes/ivpn-v3/assets/js/api/api.js | Added addDnsSubscription API method calling /web/accounts/add-dns-subscription endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
What kind of change does this PR introduce?
PR checklist
Please check if your PR fulfills the following requirements:
Does this PR introduce a breaking change?