How to use url_for in mounted router?

[flosse]

let's say I mounted a router to admin/ and use url_for within a handler of that router.

let routes = router!(
  foo: post "foo" => |req: &mut Request| {
    Ok(Response::with(Redirect(url_for!(req, "dashboard"))))
});
let admin = Chain::new(router);
let mut mounts = Mount::new();
mounts.mount("/admin", routes);

The redirect url points to /dashboard instead of /admin/dashboard.
How would you solve this?

[Hoverbear]

This is intended as far as I know:

Src

Mount a handler on a sub-path, hiding the old path from that handler.

You should be able to get the original URL using this

[flosse]

Exposing the OriginalUrl doesn't help, because url_for takes a Request :-/

[flosse]

At the moment I can see these solutions:

• a custom function that clones the request and overrides it's url with the OriginalUrl and calls url_for that reimplements url_for
• a new router method (e.g. url_for_from_original) that can be used by setting a feature mount
• hacking url_for that magically (what I dislike) uses OriginalUrl if the feature mount is set

What do you think?

[untitaker]

@flosse IMO the proper solution is to add a parent: Option<Request> attribute to Iron's core request struct and always use that inside of router.

However, we have to find out how to be able to modify a small part of the request without copying everything over.

[dbrgn]

I was also bitten by this.

@flosse did you find a solution in the meantime (as per the discussion in #133)?

[flosse]

@flosse did you find a solution in the meantime (as per the discussion in #133)?

no. But to be honest, I switched to Rocket ;-)

[reem]

I think the real long term solution to this problem is to just merge router and mount into a single API that provides both features, so they can cooperate to make these problems go away.

[dbrgn]

Yeah, that sounds useful to me. Routing and mounting are very closely related anyways :)

[dbrgn]

@reem are there already any concrete plans for such a merge?