Skip to content

[#726,#774] Migrate to pyproject.toml and add GH action for ruff #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SwooshyCueb wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[#726,#774] Migrate to pyproject.toml and add GH action for ruff #790

SwooshyCueb wants to merge 4 commits into from
+531 −43

Conversation

@SwooshyCueb
Copy link
Member

@SwooshyCueb SwooshyCueb commented Jan 23, 2026 •
edited
Loading

Addresses #726
Addresses #774

trel
trel reviewed Jan 23, 2026
View reviewed changes
@SwooshyCueb SwooshyCueb changed the title test pr [#726,#774] Migrate to pyproject.toml and add GH action for ruff Jan 23, 2026
korydraughn
korydraughn reviewed Jan 23, 2026
View reviewed changes
alanking
alanking reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@SwooshyCueb SwooshyCueb marked this pull request as draft January 26, 2026 17:31
@SwooshyCueb
Copy link
Member Author

SwooshyCueb commented Jan 26, 2026

Converting to draft, pyproject.toml might need a little more refining (and we don't want this merged before the GHA workflow lands anyway)

@SwooshyCueb SwooshyCueb marked this pull request as ready for review January 29, 2026 17:39
@SwooshyCueb
Copy link
Member Author

SwooshyCueb commented Jan 29, 2026

Ready for review.

@alanking alanking requested a review from d-w-moore January 29, 2026 18:18
@alanking
Copy link
Contributor

alanking commented Jan 29, 2026

Looks like Ruff has an opinion

@SwooshyCueb
Copy link
Member Author

SwooshyCueb commented Jan 29, 2026

Looks like Ruff has an opinion

It does. Given the teensy size of the file in question, I'm going to ignore this one. But it's a good example of what log output from ruff will look like, which @d-w-moore was asking about this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trel trel trel left review comments

@korydraughn korydraughn korydraughn left review comments

@alanking alanking alanking left review comments

@d-w-moore d-w-moore Awaiting requested review from d-w-moore

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SwooshyCueb @alanking @trel @korydraughn