Skip to content

Conversation

@d-w-moore
Copy link
Collaborator

No description provided.

Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good find. I think we should consider adding something like this to the irods/irods tests, too.

@korydraughn
Copy link
Contributor

This is a good find. I think we should consider adding something like this to the irods/irods tests, too.

Write up an issue explaining what you'd like to see happen/changed.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

@d-w-moore
Copy link
Collaborator Author

I can either "pound" at will, here, for immediate merging... or we could wait until the merge fest begins later today. But in any case, this will be the next PR to go in.

@korydraughn
Copy link
Contributor

If this is ready, squash it. If this doesn't depend on anything, go ahead and pound it.

@d-w-moore
Copy link
Collaborator Author

If this is ready, squash it. If this doesn't depend on anything, go ahead and pound it.

Affirmative, done....

@alanking alanking merged commit 266fb37 into irods:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants