Fetchcontent frendly CMakeLists.txt#295
Merged
thiagomacieira merged 1 commit intointel:mainfrom Apr 15, 2025
Merged
Conversation
Member
|
Can you squash the four commits into one and explain in the commit message why those changes are necessary to make TinyCBOR more FetchContent-friendly? The explanation in the PR text is probably sufficient, but no one looks at PR texts after committing, but they do look at commit messages via |
…n work from other libraries
jhlee525
force-pushed
the
fetchcontent-frendly
branch
from
f7d0b83 to
e108d68
Compare
Contributor
Author
|
Changed :) |
Contributor
Author
|
However still curious about my question in PR text |
Member
|
Please file an issue for the include header. You're right, the CMake conversion is incorrect. |
thiagomacieira
approved these changes
Apr 15, 2025
Contributor
Author
|
I added issue #296 If necessary, I can make following PR to resolve this problem |
Member
Please do, it's easier for me to review someone else's changes and approve than getting my own reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed CMakeLists.txt to enable
FetchContentthis library from the user library.cmake_source_dir, there was an issue where it was overridden with the parent project path when building the library usingFetchContent, causing it to not work properly. So I changedcmake_source_dirtoproject_source_dir.tinycbor/cbor.h, but has the installation path changed tocbor.h? If thecbor.hinstallation is only performed during the cmake install process, that part should also be fixed.